Added -bump-to-next flag to control which component to bump if pre-release #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made a mistake with pr #31 which ended up being closed because it did not have the right diffs. Sorry about that. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 79.59% 83.92% +4.33%
==========================================
Files 3 3
Lines 294 280 -14
==========================================
+ Hits 234 235 +1
+ Misses 49 34 -15
Partials 11 11 ☔ View full report in Codecov by Sentry. |
* main: Update circl to fix security issues Update CHANGELOG Add direnv config Ignore local .devbox env Add devbox configuration Update GitHub Actions Update depdendencies
|
Hej @yobeonline, I took the liberty to fix the linter issues in your pull-request. I will provide a review separately. |
mdomke
requested changes
Feb 25, 2024
yobeonline
changed the title
mdomke
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible values are patch (default), minor and major.
Closes #29
Details
I created the custom enum-like type
TargetReleaseVersionCompto hold values for the new flag. I gave it theValueinterface (methodsStringandSet) so that the flags package can deal with this type on its own.The
Stringmethod forTargetReleaseVersionComppanics if the integer value is not one of the enums. I don't know if it is good practice to do that (i am a golang beginner), I just felt there was no other way to deal with this case.Using
patchas default value preserves the previous behavior so that there should be no regression.